[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] ns16550: Add command line parsing adjustments
On 01/09/2017 02:10 AM, Jan Beulich wrote:
On 06.01.17 at 19:34, <ian.jackson@xxxxxxxxxxxxx> wrote:
Jan Beulich writes ("Re: [PATCH v2] ns16550: Add command line parsing
adjustments"):
On 06.01.17 at 17:24, <swapnil.paratey@xxxxxxx> wrote:
Well, as you may have seen, things are getting complicated here:
The two currently-last elements are permitted only with
CONFIG_HAS_PCI, so by adding the new fields to the end we'd
end up having two syntaxes (one with and one without PCI
support). I therefore have to modify my original proposal, and
ask for the addition to be done earlier, perhaps - using a
separator other than comma (maybe colon or semicolon) - with
the [<io-base>|pci|amt] element (as that's really the item
(possibly implicitly) specifying the I/O range, which you mean to
amend.
Why not introduce the concept of names for these endlessly multiplying
parameters ?
That's a good ides - we should indeed consider this, but then for all
of the present sub-options (retaining the nameless variant just for
backwards compatibility, and maybe only for a couple of releases.
I'm not sure Swapnil is up to a full overhaul of this parsing ...
Jan
I don't mind giving it a try.
Could you'll elaborate on the concept of names? A clear syntax of the command
line parsing options would be really helpful.
Does this mean we are adding another option? For example:
console = com1, vga
console_device = pci OR mmio OR legacyIO
com1 = 115200/3000000,8n1,0xfedc9000,4,<reg_width>,<reg_shift>
If you'll can elaborate on what to achieve, I would love to try it out.
Swapnil
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
