Re: [Xen-devel] [PATCH] xenstore: bump TDB_VERSION

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jan 09, 2017 at 07:39:32AM -0700, Jan Beulich wrote:
> Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
> the TDB layout, which - in order to not break older xenstored running
> on the same system - need to be accompanied by a version bump.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/tools/xenstore/tdb.c
> +++ b/tools/xenstore/tdb.c
> @@ -54,7 +54,7 @@
>  #endif
>  
>  #define TDB_MAGIC_FOOD "TDB file\n"
> -#define TDB_VERSION (0x26011967 + 6)
> +#define TDB_VERSION (0x26011967 + 7)

After googling around I can't find how this macro is supposed to be used
in TDB.

Looking at the code in tdb.c this is used only to check if the dump is
of a certain version, so bumping this when the layout is changed seems
sensible.

But I haven't really read all the code in that area so a second opinion
would be much appreciated.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel