[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH RFC 23/59] run: Don't collect results reported after command to stop guests is issued



From: George Dunlap <george.dunlap@xxxxxxxxxx>

Particularly on heavily-loaded systems, this can lead to skew as some
guests have already stopped processing.

Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
---
 run.go | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/run.go b/run.go
index 4222001..41408dd 100644
--- a/run.go
+++ b/run.go
@@ -172,9 +172,14 @@ func (run *BenchmarkRun) Run() (err error) {
        for i > 0 {
                select {
                case r := <-report:
-                       run.Results.Raw = append(run.Results.Raw, r)
-                       Report(Workers[r.Id], r)
+                       if ! stopped {
+                               run.Results.Raw = append(run.Results.Raw, r)
+                               Report(Workers[r.Id], r)
+                       }
                case <-done:
+                       if ! stopped {
+                               fmt.Println("WARNING: Worker left early")
+                       }
                        i--;
                        fmt.Println(i, "workers left");
                case <-timeout:
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.