Re: [Xen-devel] [RFC PATCH 4/9] x86/SVM: Modify VMCB fields to add AVIC support

[Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>]

On 12/22/16 18:11, Jan Beulich wrote:
> > > > On 19.09.16 at 07:52, <suravee.suthikulpanit@xxxxxxx> wrote:
> > --- a/xen/include/asm-x86/hvm/svm/vmcb.h
> > +++ b/xen/include/asm-x86/hvm/svm/vmcb.h
> > @@ -328,14 +328,15 @@ typedef union __packed
> >      struct
> >      {
> >          u64 tpr:          8;
> > -        u64 irq:          1;
> > +        u64 irq:          1; /* disabled for avic */
> >          u64 rsvd0:        7;
> > -        u64 prio:         4;
> > -        u64 ign_tpr:      1;
> > +        u64 prio:         4; /* disabled for avic */
> > +        u64 ign_tpr:      1; /* disabled for avic */
> >          u64 rsvd1:        3;
> >          u64 intr_masking: 1;
> > -        u64 rsvd2:        7;
> > -        u64 vector:       8;
> > +        u64 rsvd2:        6;
> > +        u64 avic_enable:  1;
> > +        u64 vector:       8; /* disabled for avic */
> For all of these, do you perhaps mean "ignored" instead of
> "disabled"?
>
> Jan
Yes, I'm fixing the comment here in my next patch.

S

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel