Hey Wei,
Sorry about the top post but I’m doing this from my phone.
That sounds good to me, you can use that commit message.
Thanks,
Alistair
On Thu, Dec 22, 2016 at 07:44:19AM -0800, Alistair Francis wrote:
> On Thu, Dec 22, 2016 at 2:54 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote:
> >> To avoid build errors related to missing file 'sys/sysctl.h' by removing
> >> the #include statement.
> >>
> >> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx>
> >
> > I can find this in Linux. Maybe this is also due to the libc you're
> > using?
>
> Yes, I think you are right. I am using musl when I see the error.
>
> >
> > On the flip side, if this header is unused anyway I think I'm fine with
> > taking this patch.
>
> Thanks, that is what I was thinking too.
>
OK. I think I will need to update the commit message to:
tools/blktap2: remove unused inclusion of sys/sysctl.h
That header file is not used. Removing it would avoid build error with
musl libc, which doesn't have that header.
If you have no objection I can make the change while committing.
Wei.
> Thanks,
>
> Alistair
>
> >
> >> ---
> >> tools/blktap2/drivers/block-remus.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tools/blktap2/drivers/block-remus.c b/tools/blktap2/drivers/block-remus.c
> >> index 079588d..7401800 100644
> >> --- a/tools/blktap2/drivers/block-remus.c
> >> +++ b/tools/blktap2/drivers/block-remus.c
> >> @@ -54,7 +54,6 @@
> >> #include <netinet/in.h>
> >> #include <arpa/inet.h>
> >> #include <sys/param.h>
> >> -#include <sys/sysctl.h>
> >> #include <unistd.h>
> >> #include <sys/stat.h>
> >>
> >> --
> >> 2.7.4
> >>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel