Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 22/12/16 21:41, Alistair Francis wrote:
> On Thu, Dec 22, 2016 at 1:15 PM, Alistair Francis
> <alistair.francis@xxxxxxxxxx> wrote:
> > On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis
> > <alistair.francis@xxxxxxxxxx> wrote:
> > > On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson <ian.jackson@xxxxxxxxxxxxx> wrote:
> > > > Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict 
> > > > -Werror checking"):
> > > > > On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> > > > > > On 20.12.16 at 20:46, <alistair.francis@xxxxxxxxxx> wrote:
> > > > > > > Signed-off-by: Alistair Francis <alistair.francis@xxxxxxxxxx>
> > > > > > Without some rationale given I don't think such changes are
> > > > > > acceptable at all. And then, as already pointed out others, the
> > > > > > use of -Werror is there not just for fun. If anything I think an
> > > > > > override to that default could be acceptable.
> > > > > Unfortunately the APPEND_CFLAGS=-Wno-error doesn't fix all the issues
> > > > > as I still see warnings/errors when building: tools/kconfig/conf.c.
> > > > That sounds like a bug to me.  Do you know why it's not effective
> > > > there ?
> > > It actually might be an issue in the way buildroot is handling the arguments.
> > >
> > > I'll look into it and see what I find after the holidays.
> I dug into this a little more. Adding the APPEND_CFLAGS="-Wno-error"
> fixes almost everything. The only problem I see is in the log below,
> where tools/kconfig/conf.c fails to build as the -Wno-error doesn't
> propagate down.
>
> If I manage to find a fix today I'll send it, otherwise this can wait
> until next year.
Something like this?

diff --git a/xen/Makefile b/xen/Makefile
index dc6862e04d..2d7a567c9c 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -253,14 +253,14 @@ kconfig := silentoldconfig oldconfig config 
menuconfig defconfig \
        randconfig
 .PHONY: $(kconfig)
 $(kconfig):
-       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
+       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" 
HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" $@
 include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG)
-       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" 
silentoldconfig
+       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" 
HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" silentoldconfig
 # Allow people to just run `make` as before and not force them to 
configure
 $(KCONFIG_CONFIG):
-       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" 
defconfig
+       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig 
ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" 
HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" defconfig
 # Break the dependency chain for the first run
 include/config/auto.conf.cmd: ;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel