[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86emul: correct 64-bit mode repeated string insn handling with zero count



On 07/12/16 10:22, Jan Beulich wrote:
On 06.12.16 at 17:35, <andrew.cooper3@xxxxxxxxxx> wrote:
On 06/12/16 13:39, Jan Beulich wrote:
@@ -5424,7 +5436,6 @@ x86_emulate(
          goto cannot_emulate;
      }
- writeback:
This removal highlights that the writeback and no_writeback lables are
incorrectly named.

There intended meaning is {no,}dest_writeback, but no_writeback still
performs a full commit of the shadow GPR state, which is what people
logically associate with the term "writeback" in this context.

I think we should have a followup patch renaming the no_writeback label
to to gpr_writeback.
I've done this, but for some of the uses of the label the new name
doesn't appear to be much better than the old one ...

Just had an idea.  How about "complete_insn" ?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.