Re: [Xen-devel] [PATCH 2/4] init/FreeBSD: remove xendriverdomain_precmd

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Wed, Dec 21, 2016 at 11:48:40AM +0000, Wei Liu wrote:
> On Mon, Dec 19, 2016 at 03:02:02PM +0000, Roger Pau Monne wrote:
> > ...because it's empty. While there also rename xendriverdomain_startcmd to
> > xendriverdomain_start in order to match the nomenclature of the file.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 8 +-------
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> > 
> > diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in 
> > b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> > index 3917de2..c71871c 100644
> > --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> > +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> > @@ -13,19 +13,13 @@ LD_LIBRARY_PATH="${libdir}"
> >  export LD_LIBRARY_PATH
> >  
> >  name="xendriverdomain"
> > -start_precmd="xendriverdomain_precmd"
> >  start_cmd="xendriverdomain_startcmd"
>                               ^^^^^^^^
>                               You missed this.
> 
> otherwise:
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Would you like to fix this while committing, or should I push the updated
series to a git branch?

Thanks, Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel