[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH 6/9] db retry: Document $@ as an implicit parameter to need_retry



There are only two call sites and neither trashes $@ right now.
We are going to use a more exception-friendly style.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 Osstest/JobDB/Executive.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
index 7eeaf52..ebafb4c 100644
--- a/Osstest/JobDB/Executive.pm
+++ b/Osstest/JobDB/Executive.pm
@@ -59,7 +59,7 @@ sub begin_work ($$$) { #method
 }
 
 sub need_retry ($$$) {
-    my ($jd, $dbh,$committing) = @_;
+    my ($jd, $dbh,$committing) = @_; # implicitly, $@ is an argument too
     return
        ($dbh_tests->err() // 0)==7 &&
        ($dbh_tests->state =~ m/^(?:40P01|40001|23|40002)/);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.