Re: [Xen-devel] [PATCH] x86/SMP: CPU0's scratch mask is needed earlier

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/12/16 09:45, Jan Beulich wrote:
> When putting together commit 3b61726458 ("x86: introduce and use
> scratch CPU mask") I failed to remember that AMD IOMMU setups needs the
> scratch mask prior to smp_prepare_cpus() having run. Use a static mask
> for the boot CPU instead.
>
> Note that the definition of scratch_cpu0mask could also be put inside a
> "NR_CPUS > 2 * BITS_PER_LONG" conditional, but it seems preferable to
> me to carry the extra variable in all cases and avoid the #ifdef-ary.
>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> I'm not particularly happy about the remaining #ifdef, but I don't see
> a way to avoid it.

Nor me.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Lets unblock staging while considering if there is a better way of doing
this.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel