Re: [Xen-devel] [PATCH v4 07/14] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Thu, Dec 08, 2016 at 09:24:08AM -0700, Jan Beulich wrote:
> >>> On 30.11.16 at 17:49, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/p2m.h
> > +++ b/xen/include/asm-x86/p2m.h
> > @@ -834,6 +834,7 @@ static inline unsigned int 
> > p2m_get_iommu_flags(p2m_type_t p2mt)
> >      case p2m_grant_map_rw:
> >      case p2m_ram_logdirty:
> >      case p2m_map_foreign:
> > +    case p2m_mmio_direct:
> >          flags =  IOMMUF_readable | IOMMUF_writable;
> >          break;
> 
> I think you need to take mmio_ro_ranges into account here.

Right, I've split p2m_mmio_direct into a separate case and added a check for
mmio_ro_ranges, this however forces all the callers of p2m_get_iommu_flags to
pass a second mfn parameter (it isn't that bad since the mfn is always
available in the call sites).

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel