Re: [Xen-devel] [PATCH] Removal of redundant check

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

Hello!

Glad to see he patch here. One thing, about the subject line: it should
contains "tags", i.e., an indication of the component that the patch
affects.

So, for example, in this case, the patch touches Credit1, which means
scheduling inside Xen. So, a valid subject line could be:

 [PATCH] xen: sched: removal of redundant check in Credit

or:

 [PATCH] xen: credit: removal of redundant check

On Wed, 2016-12-14 at 23:49 +0530, Praveen Kumar wrote:
> The patch gets rid of a redundant check in csched_vcpu_acct which
> adds
> more code clarity and performance. 
>
I'd remove "which adds more code clarity and performance" and put here
something like:

"In fact, the function is only called from csched_tick, which already
checks that current is not the idle vcpu."

> This patch also adds an ASSERT to
> the same effect, in order to make assumption ( i.e., no calling this
> on
> idle vcpus) even more clear and as a guard for future mis-use.
> 
> Signed-off-by: Praveen Kumar <kpraveen.lkml@xxxxxxxxx>
> 
Apart from what just said above, the patch looks good to me. Can you
send version 2 with the changelog updated?

Oh, and I see that you are both inlining in the email and attaching the
patch. I personally don't particularly mind, but that may make the life
of a committer (the person which, when the patch will have all the
Acks, will put it inside the Xen git repository) a bit more difficult.

So, this is mostly George's call, I think, but FWIW, I'd suggest you
avoid doing that. :-)

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel