Re: [Xen-devel] [PATCH v2 1/9] OssTest: Add target_cmd_root_status which returns return code.

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH v2 1/9] OssTest: Add 
target_cmd_root_status which returns return code."):
> All the different target_cmd_* end up calling tcmdex
> which has the unfortunate side-effect of calling 'die' if
> the SSH sessions results in any return code not zero.
> 
> That is fine, except for tests where we want to get a non-zero
> return value.
> 
> This patch adds the $badstatusok to tcmdex - and makes all
> the existing callers pass in the value of zero to it. This
> way the commands behave the normal old way.
> to all the other functions which use tcmdex.

LGTM.  (I haven't checked that you got all the call sites.)

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Hosever, if you resubmit IWBNI you would

> -    tcmdex($timeout,undef,undef,
> +    tcmdex($timeout,undef,undef, 0,
                                   ^
remove that space (throughout).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel