Re: [Xen-devel] [PATCH 2/3] vvmx: return VMfail to L1 if L1 vmxon is executed in VMX operation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/12/16 12:16, Haozhong Zhang wrote:
> According to Intel SDM, section "VMXON - Enter VMX Operation", a
> VMfail should be returned to L1 hypervisor if L1 vmxon is executed in
> VMX operation, rather than just print a warning message.
>
> Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although

> ---
>  xen/arch/x86/hvm/vmx/vvmx.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
> index f5637eb..b60d7f0 100644
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -1397,9 +1397,12 @@ int nvmx_handle_vmxon(struct cpu_user_regs *regs)
>          return rc;
>  
>      if ( nvmx_vcpu_in_vmx(v) )
> -        gdprintk(XENLOG_WARNING, 
> -                 "vmxon again: orig %"PRIpaddr" new %lx\n",
> -                 nvmx->vmxon_region_pa, gpa);
> +    {
> +        vmreturn(regs,
> +                 nvcpu->nv_vvmcxaddr != VMCX_EADDR ?
> +                 VMFAIL_VALID : VMFAIL_INVALID);

vmreturn really should take a single fail option and internally turn
this into VMFAIL_{VALID,INVALID}, rather than requiring the caller to do so.

~Andrew

> +        return X86EMUL_OKAY;
> +    }
>  
>      nvmx->vmxon_region_pa = gpa;
>  


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel