Re: [Xen-devel] [PATCH 4/8] libelf: loop safety: Call elf_iter_ok_counted at every *mem*_unsafe

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.12.16 at 16:44, <ian.jackson@xxxxxxxxxxxxx> wrote:
> @@ -80,7 +81,8 @@ void elf_memcpy_safe(struct elf_binary *elf, elf_ptrval dst,
>  
>  void elf_memset_safe(struct elf_binary *elf, elf_ptrval dst, int c, size_t 
> size)
>  {
> -    if ( elf_access_ok(elf, dst, size) )
> +    if ( elf_access_ok(elf, dst, size) &&
> +         elf_iter_ok_counted(elf, size))

With the style issue here fixed,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
despite not being really happy about the added clutter.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel