Re: [Xen-devel] [PATCH v3 4/5] tools/libacpi: update FADT layout to support version 5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.16 at 11:45, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Dec 07, 2016 at 09:04:14AM -0700, Jan Beulich wrote:
>> >>> On 05.12.16 at 16:04, <roger.pau@xxxxxxxxxx> wrote:
>> > --- a/tools/firmware/hvmloader/util.c
>> > +++ b/tools/firmware/hvmloader/util.c
>> > @@ -949,7 +949,7 @@ void hvmloader_acpi_build_tables(struct acpi_config 
>> > *config,
>> >          config->table_flags |= ACPI_HAS_SSDT_S4;
>> >  
>> >      config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC | 
>> > ACPI_HAS_WAET |
>> > -                            ACPI_HAS_VGA | ACPI_HAS_8042);
>> > +                            ACPI_HAS_VGA | ACPI_HAS_8042 | ACPI_FADT_4);
>> 
>> It shouldn't be an explicit FADT version that gets requested, but
>> a specific ACPI version (and I don't think a boolean flag is suitable
>> for this).
> 
> Hm, I'm not opposed to this, but maybe then there are other tables to be 
> bumped 
> if we really want to request a specific ACPI version?

Indeed. But I can't reasonably expect you to do the entire switch
within this series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel