[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/36] qdict: Add convenience helpers for wrapped puts


  • To: Eric Blake <eblake@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
  • From: Alberto Garcia <berto@xxxxxxxxxx>
  • Date: Fri, 09 Dec 2016 15:06:48 +0100
  • Cc: Kevin Wolf <kwolf@xxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Fam Zheng <famz@xxxxxxxxxx>, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, Chrysostomos Nanakos <chris@xxxxxxxxxx>, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Jeff Cody <jcody@xxxxxxxxxx>, Peter Lieven <pl@xxxxxxx>, armbru@xxxxxxxxxx, Max Reitz <mreitz@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, pbonzini@xxxxxxxxxx, "open list:Block layer core" <qemu-block@xxxxxxxxxx>, Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>, "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>
  • Delivery-date: Fri, 09 Dec 2016 14:17:18 +0000
  • Ironport-phdr: 9a23:wOLDIhWtsATvPX3xC1yRi8fMrtXV8LGtZVwlr6E/grcLSJyIuqrYZR2EuqdThVPEFb/W9+hDw7KP9fuxAipdv93b6zgrS99lb1c9k8IYnggtUoauKHbQC7rUVRE8B9lIT1R//nu2YgB/Ecf6YEDO8DXptWZBUhrwOhBoKevrB4Xck9q41/yo+53Ufg5EmCexbal8IRiyowjdrMkbjIptJqovxBbCv2dFdflRyW50P1yYggzy5t23/J5t8iRQv+wu+stdWqjkfKo2UKJVAi0+P286+MPkux/DTRCS5nQHSWUZjgBIAwne4x7kWJr6rzb3ufB82CmeOs32UKw0VDG/5KplVBPklCEKPCMi/WrJlsJ/kr5UoBO5pxx+3YHUZp2VNOFjda/ZZN8WWHZNUtpUWyFHH4iybZYAD/AZMOhYsYfzulkBrRWwCgeiB+3gxSNHi2Tq3aEmyektDR3K0RY8E98IrX/arM/1NKAXUe2t0KTIyS7MYO1M2Tfh74jDbxEvruuWXb1scMre01QkGgTegVqOs4zlIzSV2/8Ms2iU9eVgUeOvhHQ9pw5tpTivw94hh4/UjYwW0lDJ7SF0zJsvKdGlVUJ2Y8SoHZ9Uui2AKod7QsMvTmd1sygg0LIGo4S0fC0SxZQiwB7QduKIfpCT4hLmSOaROTB4hG95eL6nhxa970ygyurkW8m6yllKqCtEktjKtn8TzRDT68eHReF5/kegwzmDzRzc6uZBIUwslKrbLYAuwqIom5cXrEjPBDL6lFj0gaOMckgp/vKk5/nnb7jmvpOcMpV7igD6MqQggMy/BuE4PxAVUGeF4+S8yLrj8Fb4QLVFlPI2lqjZv4rAKcsHoa65BhdZ0pw/5BanEzemzNMYkGEZI11efBKIlYvpNE/VLfDiE/iwnlSsny13x/zcIrLhBZDNJGDZkLj9ZbZ991JcyA0rwNBG+Z1UD6wBLOvuVUDvqtzXEBs5Pheyw+bgDtV92YUeWX+VDq+eKqPSvkeC5vgzLOmUeI8VpDH9JuA/6P70iH82gkUdfbSy0JsNdn+3A/RmLF+FYXb2ntgBFmIKtBIkTOP2kF2CTSJTZ3GqUqIk/T47D4SmDIbCRoCrgbyMxz27EYNLaWBGEF+MDW3keJmDW/cJcCiSONNukiQYVbi9TI8szRKutQH9y7pjIOrZ4TcYuoz+29h1/eLTiQs++iBzD8SYy2uNVX17nnsURz8q26ByuUl9yk2d3qh5n/xZFMde5+lXXQgnNZ7T1fB6B8ruVQLGe9eDUEymTcm+ATEtUtIxxMcDbFp9G9W4jxDDxDGnA74Tl7OXAJw077/T0GbrK8Zy0XbMzLMhgEU+QstTKW2mgbZy9wrPCI7OjkqYl72ndb4C0yHQ9GeM13aOsFtEXw53VKXPRWofaVfOrdTl+kPCSKejCa87MgRfx86NMK1Kat3zglhdXvfsJsnRY2KrlGesHxqH2rSMbI/ycWUHwCrdEFQEkxwU/XueLwg+ASGho2TfDDNwDlLgeUPs8e1lp3ylVE80wBqHb0Jk17Wv+x4VgeaQRO8U3rIBoC0hsSl7HE6h39LKDNqNvxJhfKFHbNM++lhH0HrZuxZgMZO+N6pinEIRcxxrv0Py0BV6EotAntIvrHIr1wdyM7yX305BdzyCwZD8IKHYKm73/Bq3ca7Zxkne0MqK+qcI8Pk4sFvisRqnF0U88nVn199V3GWA5pTLFgYdTIz+WF4t9xdmv7HafjU954TM2H12M6m0tTnC1MwyBOY+0BavYcpQMKOeGw/uCcEVG8+uKOkykVizch0EJPxS9LIzP86+bPuGw7KrM/x7kz24iWRH5IF90kSN9ydnSe7HwYwFw/eG0QuDTTv8i02hss/vk4BeeT4SBna/yTTjBINJfKJye5oLCWepI82xxtRynYbtVGBC9FG5HVMJxdSkdgaTb1zhxw1Q1EsWrWa7liu/yjx+iyspobaH3CzS3+TicwIKOm1RRGZ4glbjP4y0gssAXEe2cgcplAGq5Vrgy6dHo6R/KnHZQV1UcCjuM2FiTqywu6KfbM5A6ZMotT5YX/qmYVCGUbP9uQUV3D7jH2RE2DA3bS2lupL8nxZikmKSMG5zrGbFecF33Rrf4cHTReRW3joaRCl1kj3XBlm6P9m08tSYjYnDsuagWGK9TJFTcDLkzYaauCSn4m1qBAW1n+qvld3/DQg6zSj72sFwVSXUrBbxeZXr1qq7Me16Y0ZoAEHz59B8Go5gjos6nIsQ1mQChpWJ4XoHln/+Ps9U2aLkdnUNSyUGw8XI4Aj+xkJvNG+GyJzhXHWH3sRhf8W6Yn8R2i8l9sBFFqKU7KFdkSRuplq4qh7eYftmkzcbzvsu7nEag+cUuAY3ySWdGL8SF1FCPSPwjxSI88y+rKJPaWegb7ew0lNyks2/A7GcvA5cXG30epMjHS9r8sV/K0jA0XLt5YHiY9nQas8TtgeInBjeleRaNJUxlv9ZzRZgbE/nvHZt4eoyjhEmiZywuIGEJk138a65CwIePTrwMYdb4zzokONSk9ib26ipGZNuHChNW4HnHtyyFzdHnPDtOhySF3UTo22QGLOXSQWS8lthh3PAGpSqPjecI3xPnoYqfwWUOEEK2FNcZz49hJNsU1nynME=
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On Wed 30 Nov 2016 08:44:20 PM CET, Eric Blake wrote:
> Quite a few users of qdict_put() were manually wrapping a
> non-QObject. We can make such call-sites shorter, by providing
> common macros to do the tedious work.  Also shorten nearby
> qdict_put_obj(,,QOBJECT()) sequences.
>
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>

Thanks, the code looks much better now :)

Reviewed-by: Alberto Garcia <berto@xxxxxxxxxx>

Berto

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.