Re: [Xen-devel] [PATCH v3 2/5] x86emul: don't assume a memory operand

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/12/16 11:13, Jan Beulich wrote:
> @@ -2359,7 +2360,7 @@ x86_decode(
>          }
>      }
>  
> -    if ( override_seg != -1 && ea.type == OP_MEM )
> +    if ( override_seg != x86_seg_none )
>          ea.mem.seg = override_seg;

Could we get away with asserting ea.type == OP_MEM if override_seg is
set, to help validate our assumptions about state?  (Possibly even
passing #UD back in the non-debug case)

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel