Re: [Xen-devel] [PATCH v1] arm/irq: Reorder check when the IRQ is already used by someone

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Mon, 5 Dec 2016, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 02/12/16 16:38, Oleksandr Tyshchenko wrote:
> > Call irq_get_domain for the IRQ we are interested in
> > only after making sure that it is the guest IRQ to avoid
> > ASSERT(test_bit(_IRQ_GUEST, &desc->status)) triggering.
> > 
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> I forgot to mention that your Signed-off-by does not match the From.
> In the future, please make sure that the author e-mail (the From) is listed in
> the signed-off.

CC'ing Lars.

Actually I don't think this is required: Signed-off-by is about
copyright ownership, that is where using the company email is important.
But I don't think it is necessary for the authorship, that is what From:
is about. Authorship is just to give credit to the author, it could be a
pseudonym, I think. I am pretty sure that I have seen other instances
of this on the LKML.

For example:

Alice works for Bob
Alice writes a patch, Bob has copyright ownership
Chris takes Alice's patch and sends it to xen-devel

Chris should use its own email address in the email From: field; he uses
Alice's email address (doesn't matter which) in the From: field within
the patch; he should use Bob's email as Signed-off-by:

    From: Chris
    Subject: [PATCH] fix something

    From: Alice
    This patch fixes something

    Signed-off-by: Bob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel