Re: [Xen-devel] [PATCH 3/8] x86/hvm: Assert some expectations in hvm_inject_event()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.16 at 11:09, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1679,6 +1679,15 @@ void hvm_triple_fault(void)
>  void hvm_inject_event(const struct x86_event *event)
>  {
>      struct vcpu *curr = current;
> +    const uint8_t vector = event->vector;
> +    const bool has_ec = ((event->type == X86_EVENTTYPE_HW_EXCEPTION) &&
> +                         (vector < 32) && ((TRAP_HAVE_EC & 1u << vector)));

With the operands of << parenthesized
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel