Re: [Xen-devel] [PATCH v4 07/12] xenstore: use array for xenstore wire command handling

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Dec 05, 2016 at 01:43:40AM -0700, Jan Beulich wrote:
> >>> On 05.12.16 at 08:48, <JGross@xxxxxxxx> wrote:
> > @@ -1304,12 +1275,51 @@ static void do_debug(struct connection *conn, 
> > struct buffered_data *in)
> >     send_ack(conn, XS_DEBUG);
> >  }
> >  
> > +static struct {
> > +   char *str;
> > +   void (*func)(struct connection *conn, struct buffered_data *in);
> > +} wire_funcs[XS_TYPE_COUNT] = {
> 
> If this was hypervisor code, I would demand both the array as a
> whole and the str member to become constified. Not sure what the
> tool stack side non-library policy is.
> 

I think that's a good idea. No need to resend for this. I can change it
while committing.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel