Re: [Xen-devel] [PATCH v2 1/4] tools/libacpi: add _FADT_ to the FADT boot flags definitions

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Fri, Dec 02, 2016 at 01:53:44PM +0000, Andrew Cooper wrote:
> On 02/12/16 13:48, Roger Pau Monne wrote:
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: boris.ostrovsky@xxxxxxxxxx
> > Cc: konrad.wilk@xxxxxxxxxx
> > ---
> >  tools/libacpi/acpi2_0.h | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h
> > index 775eb7a..5ddef8a 100644
> > --- a/tools/libacpi/acpi2_0.h
> > +++ b/tools/libacpi/acpi2_0.h
> > @@ -227,9 +227,8 @@ struct acpi_20_fadt {
> >  /*
> >   * FADT Boot Architecture Flags.
> >   */
> > -#define ACPI_LEGACY_DEVICES (1 << 0)
> > -#define ACPI_8042           (1 << 1)
> > -
> > +#define ACPI_FADT_LEGACY_DEVICES    (1 << 0)
> > +#define ACPI_FADT_8042              (1 << 1)
> 
> It would be better to retain the newline here,  Otherwise, Reviewed-by:
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Right, I somehow managed to screw it. I've pushed a new version with the 
newline 
issue fixed, it's at:

git://xenbits.xen.org/people/royger/xen.git libacpi_bootflags_v2

Sorry, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel