Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

[Tim Deegan <tim@xxxxxxx>]

At 11:23 +0000 on 01 Dec (1480591394), Andrew Cooper wrote:
> Hmm.  It is only the PAE case we want to skip.  Perhaps changing the PAE
> entry condition to
> 
> diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
> index c45d260..28ff945 100644
> --- a/xen/arch/x86/mm/shadow/multi.c
> +++ b/xen/arch/x86/mm/shadow/multi.c
> @@ -3480,7 +3480,7 @@ static int sh_page_fault(struct vcpu *v,
>      }
>  
>  #if GUEST_PAGING_LEVELS == 3 /* PAE guest */
> -    if ( r == X86EMUL_OKAY ) {
> +    if ( r == X86EMUL_OKAY && !emul_ctxt.ctxt.retire.raw ) {
>          int i, emulation_count=0;
>          this_cpu(trace_emulate_initial_va) = va;
>          /* Emulate up to four extra instructions in the hope of catching
> 
> would be better, along with suitable comments and style fixes?

That would be OK by me, and with that change,

Acked-by: Tim Deegan <tim@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel