[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 08/24] x86/emul: Correct the behaviour of pop %ss and interrupt shadowing



>>> On 01.12.16 at 11:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/12/16 10:18, Jan Beulich wrote:
>>>>> On 30.11.16 at 14:50, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>>> @@ -2656,6 +2656,8 @@ x86_emulate(
>>>                                &dst.val, op_bytes, ctxt, ops)) != 0 ||
>>>               (rc = load_seg(src.val, dst.val, 0, NULL, ctxt, ops)) != 0 )
>>>              goto done;
>>> +        if ( src.val == x86_seg_ss )
>>> +            ctxt->retire.mov_ss = 1;
>>>          break;
>> While I don't mind it being done here (i.e. it can have my R-b as is),
>> wouldn't it be even better to put this into load_seg() itself?
> 
> That would cause the mov_ss flag to be incorrectly set for `lss`.

Oh, good point. So as said,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.