Re: [Xen-devel] [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/11/16 13:00, Julien Grall wrote:
> Hi Andrew,
>
> On 25/11/16 19:12, Andrew Cooper wrote:
>> On 25/11/16 19:06, Julien Grall wrote:
>>> The tools (such as mk_dsdt) can be cross-built when it may not be
>>> desirable to build them on the target.
>>>
>>> The commit c4ac1077 "libxl/arm: Generate static ACPI DSDT table"
>>> introduced support of ARM64 in mk_dsdt but also break cross-building
>>> tools because the ACPI tables are not correct.
>>>
>>> While mk_dsdt should generate ACPI table for the target
>>> architecture, it
>>> currently generates the one for the host. This is because the source
>>> code contains reference to the host architecture (__aarch64__,
>>> __x86_64__, __i386__) when it should be the target architecture.
>>>
>>> Replace all __aarch64__, __x86_64__, __i386__ by the corresponding
>>> CONFIG_*.
>>>
>>> Also expose the CONFIG_* to the source code as the currently only
>>> exposed to the Makefile.
>>>
>>> Reported-by: Andrii Anisov <andrii.anisov@xxxxxxxxx>
>>> Suggested-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
>>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, with one tweak,
>
> Jan asked few changes in the patch. Can I keep the reviewed-by on the
> next version?

Yes.  Fine by me.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel