Re: [Xen-devel] [PATCH LIVEPATCH-BUILD-TOOLS] Fix patch creation with GCC 6.1+

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 11/24/2016 12:31 PM, Konrad Rzeszutek Wilk wrote:
> On November 24, 2016 4:49:20 AM EST, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> 
> wrote:
> > GCC 6.1+ fixed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=192 which
> > means that .rodata.str* sections are now split by function.  We could
> > probably be smarter about including just the sections we need, but for
> > now, include all .rodata.str* sections as is done for previous versions
> > of GCC.
> Here you say .str*
>
> But the code only does this for .str1.*
>
> Did you mean to make it.more generic for say .rodata.*.str[0-9].*
>
> ?
The code is what I intended. I tweaked the commit message slightly:

GCC 6.1+ fixed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=192 which 
means that .rodata.str1.[0-9]+ sections are now split by function.  We 
could probably be smarter about including just the sections we need, but 
for now, simply include the string sections for all functions as is done 
for previous versions of GCC.
--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel