Re: [Xen-devel] [PATCH 04/35] libxl.c: switch to LOG*D use

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Nov 17, 2016 at 05:03:03PM +0100, Cedric Bosdonnat wrote:
> On Thu, 2016-11-17 at 14:50 +0000, Wei Liu wrote:
> > On Tue, Nov 15, 2016 at 11:18:42AM +0100, Cédric Bosdonnat wrote:
> > > Use LOG*D functions to output the domain ID in logs as much as
> > > possible. This will help consumer code sorting the logs by
> > > domain.
> > > 
> > > This commit includes all LOG* to LOG*D changes where the domain
> > > ID is not just a domid variable. We want the domain ID provided
> > > to the LOG*D functions to be the one of the publicly known
> > > domain, not a stubdom one.
> > > 
> > > Signed-off-by: Cédric Bosdonnat <cbosdonnat@xxxxxxxx>
> > 
> > I skimmed through the rest of this series. The code looks good to me.
> > 
> > The only thing I don't understand is why you had patch 2-4 for libxl.c.
> > These three patches can probably be merged into one patch.
> 
> That was to ease the review by isolating the cases that could be problematic.
> But I'll resubmit them merged together then.
> 

In that case please keep them separated.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel