Re: [Xen-devel] [RFC PATCH KERNEL 1/4] x86/xen: start untangling PV and PVHVM guest support code

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 14/11/16 17:17, Vitaly Kuznetsov wrote:
> Introduce CONFIG_XEN_PV config option and split enlighten.c into
> 3 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
> not break the build and not make the patch even bigger.
> 
> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
> future xen_smp_intr_init() split.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/hypervisor.h |   3 +-
>  arch/x86/kernel/cpu/hypervisor.c  |   7 +-
>  arch/x86/kernel/process_64.c      |   2 +-
>  arch/x86/xen/Kconfig              |  25 ++-
>  arch/x86/xen/Makefile             |   7 +-
>  arch/x86/xen/enlighten.c          | 388 
> ++------------------------------------
>  arch/x86/xen/enlighten_common.c   | 216 +++++++++++++++++++++
>  arch/x86/xen/enlighten_hvm.c      | 202 ++++++++++++++++++++

I think I'd prefer:

enlighten.c, enlighten_pv.c and enlighten_hvm.c

And similarly for the other files you split.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel