Re: [Xen-devel] [PATCH v2 09/11] events/x86: Define SCI virtual interrupt

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.16 at 15:39, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/event.h
> +++ b/xen/include/asm-x86/event.h
> @@ -38,9 +38,10 @@ static inline void local_event_delivery_enable(void)
>      vcpu_info(current, evtchn_upcall_mask) = 0;
>  }
>  
> -/* No arch specific virq definition now. Default to global. */
>  static inline int arch_virq_is_global(uint32_t virq)
>  {
> +    if ( virq == VIRQ_SCI )
> +     return 0;
>      return 1;
>  }

Why is SCI per-CPU? (And if so, please use "return virq != VIRQ_SCI".)
It's certainly conceptually a global one in the native case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel