Re: [Xen-devel] [PATCH v3 05/12] xenstore: add support for reading directory with many children

[Juergen Gross <jgross@xxxxxxxx>]

On 11/11/16 12:12, Jan Beulich wrote:
>>>> On 11.11.16 at 11:43, <JGross@xxxxxxxx> wrote:
>> On 11/11/16 11:09, Jan Beulich wrote:
>>>>>> On 11.11.16 at 09:00, <JGross@xxxxxxxx> wrote:
>>>> --- a/xen/include/public/io/xs_wire.h
>>>> +++ b/xen/include/public/io/xs_wire.h
>>>> @@ -50,6 +50,9 @@ enum xsd_sockmsg_type
>>>>      XS_SET_TARGET,
>>>>      XS_RESTRICT,
>>>>      XS_RESET_WATCHES,
>>>> +    XS_DIRECTORY_PART,
>>>> +
>>>> +    XS_NEXT_ENTRY,      /* First unused type. */
>>>
>>> What is this needed for?
>>
>> Patch 7. I didn't want to modify the same enum twice in the same series.
>> In case you'd prefer to add XS_NEXT_ENTRY in patch 7 I'd be happy to
>> move it.
> 
> Yes please. Additions should be made where they are needed;
> please don't forget that series' may be committed in pieces. Also
> judging about the chosen name (which I consider somewhat odd -
> I'd have expected something like XS_TYPE_COUNT) is easier when
> one sees the intended use.

Okay to both (moving and renaming to your suggested name).


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel