[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.8] flask: build policy in different locations


  • To: Wei Liu <wei.liu2@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Date: Thu, 3 Nov 2016 11:17:59 -0400
  • Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 03 Nov 2016 15:18:19 +0000
  • Ironport-phdr: 9a23:G3LnohzTtVATxEbXCy+O+j09IxM/srCxBDY+r6Qd0OgQIJqq85mqBkHD//Il1AaPBtSBraIbwLeK+4nbGkU4qa6bt34DdJEeHzQksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2WVTerzWI4CIIHV2nbEwud76zStGZ0pj//tvx0qWbWx9Piju5bOE6BzSNhiKViPMrh5B/IL060BrDrygAUe1XwWR1OQDbxE6ktY+YtaRu+CVIuv8n69UIEeCjJ/x5HoFCCHwaF0x9pIix7ViQBTeIs0QRUy0ykwcAVxfI7Vf+X4qrmiD7qvB8yG+ROsigCfgEVDLn46p1RRug3DcKMXs1/X/ajuR0jblHu1Sxqhpn2YnWbYqJcv1kcfWOU8kdQD9tV8BQWigJLo70QJEGBuRJaepXo4TyvVImsQq1BQ7qAvjmjDBPmCmljuUBz+09HFSej0QbFNUUvSGR9Y+tOQ==
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 10/28/2016 11:17 AM, Wei Liu wrote:
The flask policy can be build twice -- one for hypervisor and one for
tools.

Before this patch, everything is built inside tools/flask/policy
directory.  It is possible to have a race to write to the same output
file when running parallel builds.

Prepend output file names with FLASK_BUILD_DIR. Hypervisor and tools
build will set that variable to different directories, so that we can
be safe from races.

Adjust other bits of the build system as needed.

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Pulling the definition of POLICY_FILENAME out of Makefile.common might
remove the need for the cmp||cp line in the xen-side Makefile, but that
probably belongs in another patch.

--
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.