Re: [Xen-devel] [PATCH v3.1 05/15] x86/paging: introduce paging_set_allocation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.10.16 at 10:59, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -1609,13 +1609,7 @@ shadow_free_p2m_page(struct domain *d, struct 
> page_info *pg)
>      paging_unlock(d);
>  }
>  
> -/* Set the pool of shadow pages to the required number of pages.
> - * Input will be rounded up to at least shadow_min_acceptable_pages(),
> - * plus space for the p2m table.
> - * Returns 0 for success, non-zero for failure. */
> -static int sh_set_allocation(struct domain *d,
> -                             unsigned int pages,
> -                             int *preempted)
> +int sh_set_allocation(struct domain *d, unsigned int pages, bool *preempted)

Iirc functions with a name starting with sh_ are shadow code internal,
so you may better switch to shadow_set_allocation(). Tim?

With that taken care of (unless Tim indicates there's no need),
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel