Re: [Xen-devel] [PATCH v2 for-4.9 2/2] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/10/16 11:16, Jan Beulich wrote:
>>>> On 26.10.16 at 11:57, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 26/10/16 10:54, Jan Beulich wrote:
>>>>>> On 26.10.16 at 11:48, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>> Wei: Turns out that I typo'd the subject, and I meant "for 4.8" here, as
>>>> this is a bugfix in the emulator.  Please can I get a view towards a
>>>> release ack?
>>> Oh, I didn't even realize that v2 has become a bugfix instead of mere
>>> simplification. Somehow I had been under the impression that
>>> decode_segment() behaved correctly. Perhaps the subject should
>>> then be changed?
>> I was entirely accidentally a bugfix, but a bugfix none the less.
>>
>> I am open to changing the title.  How about "Correct the decoding of
>> SReg3 operands"?
> SGTM, together with some adjustment to the description then (as
> the original patch purpose now has become a cleanup side effect).

Text now reads:

x86/emul: Correct the decoding of SReg3 operands

REX.R is ignored when considering segment register operands, and needs
masking
out first.

While fixing this, reorder the user segments in x86_segment to match SReg3
encoding.  This avoids needing a translation table between hardware ordering
and Xen's ordering.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel