Re: [Xen-devel] [PATCH RFC 0/2] Fix PAGE_SIZE issues in public headers

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 19 Oct 2016, Juergen Gross wrote:
> On 19/10/16 12:46, Wei Liu wrote:
> > Reference to PAGE_SIZE slipped in to two public header files. QEMU build on
> > ARM64 is broken by this.
> > 
> > This series tries to fix that. The approach is discussed at [0].
> > 
> > QEMU will need to update its copy of usbif.h.
> 
> There is no QEMU copy of Xen headers. This is the reason why an
> imcompatible change is not possible. With the patches there is no
> longer an urgent need for qemu to be modified.

Yes, as long as we backport the fixes to the Xen stable trees as soon as
possible.


> > It would be good if we can have this fixed either by this series or some 
> > other
> > method for 4.8 to avoid releasing problematic headers for another release.
> 
> Both patches:
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> 
> 
> Thanks,
> 
> Juergen
> 
> > 
> > Wei.
> > 
> > [0] <alpine.DEB.2.10.1610181145470.16441@sstabellini-ThinkPad-X260>
> > 
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > 
> > Wei Liu (2):
> >   usbif.h: don't require PAGE_SIZE to be present
> >   vscsiif.h: don't require PAGE_SIZE to be present
> > 
> >  xen/include/public/io/usbif.h   | 24 ++++++++++++++++++++++--
> >  xen/include/public/io/vscsiif.h | 18 +++++++++++++++++-
> >  2 files changed, 39 insertions(+), 3 deletions(-)
> > 
> > --
> > 2.1.4
> > 
> > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel