Re: [Xen-devel] [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2016年10月10日 21:55, Konrad Rzeszutek Wilk wrote:
> On Sat, Oct 08, 2016 at 11:26:44AM +0800, Lan Tianyu wrote:
>> On 2016年10月06日 20:52, Jan Beulich wrote:
>>>>>> On 30.09.16 at 04:19, <tianyu.lan@xxxxxxxxx> wrote:
>>>> @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct 
>>>> cpu_user_regs *regs)
>>>>      if ( key >= ARRAY_SIZE(key_table) || !(h = &key_table[key])->fn )
>>>>          return;
>>>>  
>>>> -    if ( !in_irq() || h->irq_callback )
>>>> +    if ( h->irq_callback )
>>>
>>> Please make subject/description reflect this: You don't _always_
>>> force the use of the tasklet.
>>
>> Ok. I also find register_irq_keyhandler() isn't called anywhere in
>> current code and that means none uses irq_callback. Can we remove it?
> 
> But it is. See IRQ_KEYHANDLER

Oh. Yes. Thanks for your information.

-- 
Best regards
Tianyu Lan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel