Re: [Xen-devel] [PATCH v2] xenbus: advertize control feature flags

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: David Vrabel [mailto:david.vrabel@xxxxxxxxxx]
> Sent: 10 October 2016 11:16
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>; Juergen Gross
> <jgross@xxxxxxxx>
> Subject: Re: [PATCH v2] xenbus: advertize control feature flags
> 
> On 10/10/16 10:43, Paul Durrant wrote:
> > The Xen docs specify several flags which a guest can set to advertize
> > which values of the xenstore control/shutdown key it will recognize.
> > This patch adds code to write all the relevant feature-flag keys.
> [...]
> >  static int setup_shutdown_watcher(void)
> >  {
> > +   static struct shutdown_handler *handler;
> >     int err;
> >
> > +   for (handler = &shutdown_handlers[0]; handler->command;
> handler++) {
> > +           char *node;
> 
> char node[20];

I didn't want to pick arbitrary numbers. I'd prefer to stick with kasprintf().

  Paul

> 
> and avoid the allocation and resulting error path.
> 
> As Juergen notes, the 'flag' field isn't used anywhere now.  Can you
> please test your patches and verify the correct keys are being created?
> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel