Re: [Xen-devel] [RFC PATCH 5/8] gcov: userspace tools to extract and split gcov data

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 07, 2016 at 11:47:13AM +0100, Andrew Cooper wrote:
> On 06/10/16 15:37, Wei Liu wrote:
> > Provide two tools: a small C program to extract data from hypervisor and
> > a python script to split data into multiple files.
> >
> > The file xencov.c is salvaged and modified from the original xencov.c.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > ---
> >  tools/misc/Makefile     |   6 ++
> >  tools/misc/xencov.c     | 148 
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> >  tools/misc/xencov_split | 100 ++++++++++++++++++++++++++++++++
> >  3 files changed, 254 insertions(+)
> >  create mode 100644 tools/misc/xencov.c
> >  create mode 100755 tools/misc/xencov_split
> >
> > diff --git a/tools/misc/Makefile b/tools/misc/Makefile
> > index 5ba6672..c029401 100644
> > --- a/tools/misc/Makefile
> > +++ b/tools/misc/Makefile
> > @@ -13,6 +13,7 @@ CFLAGS += $(CFLAGS_libxenstore)
> >  INSTALL_BIN-$(CONFIG_X86)      += xen-cpuid
> >  INSTALL_BIN-$(CONFIG_X86)      += xen-detect
> >  INSTALL_BIN                    += xencons
> > +INSTALL-BIN                    += xencov_split
> 
> You have typo'd INSTALL_BIN here, causing xencov_split not to be
> installed.  (Luckily, RPM catches this, but I have spent a while staring
> in disbelief, trying to work out what was wrong.)
> 

I stared at the two lines for 30s and finally figured out that went
wrong.

Sorry about this! I will fix that in v2.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel