Re: [Xen-devel] [PATCH 22/24] xen: credit2: "relax" CSCHED2_MAX_TIMER

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 17/08/16 18:20, Dario Faggioli wrote:
> Credit2 is already event based, rather than tick
> based. This means, the time at which the (i+1)-eth
> scheduling decision needs to happen is computed
> during the i-eth scheduling decision, and a timer
> is set accordingly.
> 
> If there's nothing imminent (or, the most imminent
> event is really really really far away), it is
> ok to say "well, let's double-check things in
> a little bit anyway", but such 'little bit' does
> not need to be too little, as, most likely, it's
> just pure overhead.
> 
> The current period, for this "safety catch"-alike
> timer is 2ms, which indeed is high, but it can
> well be higher. In fact, benchmarks show that
> setting it to 10ms --combined with other
> optimizations-- does actually improve performance.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

We might as well toss this one in:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel