Re: [Xen-devel] [PATCH 1/2] tools/libxc: Don't leak foreign mappings when loading modules

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 30, 2016 at 11:01:03AM +0100, Andrew Cooper wrote:
> Spotted by Coverity
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
>  tools/libxc/xc_dom_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
> index 5326d36..e177667 100644
> --- a/tools/libxc/xc_dom_core.c
> +++ b/tools/libxc/xc_dom_core.c
> @@ -1119,6 +1119,7 @@ static int xc_dom_load_acpi(struct xc_dom_image *dom)
>          }
>  
>          memcpy(ptr, dom->acpi_modules[i].data, dom->acpi_modules[i].length);
> +        munmap(ptr, XC_PAGE_SIZE * num_pages);
>  
>          free(extents);
>          i++;
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel