Re: [Xen-devel] [PATCH v8 04/13] x86: properly calculate xen ELF end of image address

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.16 at 09:51, <daniel.kiper@xxxxxxxxxx> wrote:
> On Thu, Sep 29, 2016 at 01:34:30AM -0600, Jan Beulich wrote:
>> >>> On 29.09.16 at 00:51, <daniel.kiper@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/Makefile
>> > +++ b/xen/arch/x86/Makefile
>> > @@ -91,7 +91,7 @@ endif
>> >
>> >  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>> >    ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 0x100000 \
>> > -  `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
>> > +          `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . _end$$/0x\1/p'`
>>
>> I thought we had agreed to use __2M_rwdata_end here.
> 
> Oh, I forgot about that.
> 
>> And also note that I had said "such that the command line argument
>> here aligns with the first one on the previous line" in my reply to v7
>> regarding the indentation change.
> 
> $(TARGET)-syms starts in the same column as $(notes_phdrs) does in the
> final output as you requested. However, here it looks that it is
> misaligned due to tab at the begging of the line.

I specifically looked at this in an editor using a fixed width font,
and I just took a look another time: I cannot confirm what you
say - the first back quote sits under the k of mkelf32. Or wait -
what you say is true, but is not what I had asked for. The whole
back-quoted string is an argument to mkelf32.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel