Re: [Xen-devel] [PATCH v1 05/12] tmem: Delete deduplication (and tze) code.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Sep 28, 2016 at 06:34:19AM -0600, Jan Beulich wrote:
> >>> On 28.09.16 at 11:42, <konrad.wilk@xxxxxxxxxx> wrote:
> > Couple of reasons:
> >  - It can lead to security issues (see row-hammer, KSM and such
> >    attacks).
> >  - Code is quite complex.
> >  - Deduplication is good if the pages themselves are the same
> >    but that is hardly guaranteed.
> >  - We got some gains (if pages are deduped) but at the cost of
> >    making code less maintainable.
> >  - tze depends on deduplication code.
> > 
> > As such, deleting it.
> 
> So why the prior two patches then? That way you've got more to
> delete here than without.

Um. I thought it would be easier to understand which parts of 
the code are it by first putting a bunch of #ifdefs around it.

But the end result is the same - code gets removed. I will squash
those two patches in this one.

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel