Re: [Xen-devel] [PATCH v2 03/30] xen/x86: fix parameters and return value of *_set_allocation functions

[Tim Deegan <tim@xxxxxxx>]

At 17:56 +0200 on 27 Sep (1474999018), Roger Pau Monne wrote:
> Return should be an int, and the number of pages should be an unsigned long.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Both those changes seem fine to me.  Since you're changing the return
types to int, can you please also change the two callers (hap_enable()
and shadow_enable()) that assign it to an unsigned variable?  AFAICS
both should just pass the result through instead of forcing all errors
to -ENOMEM.

Cheers,

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel