Re: [Xen-devel] [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread

[Simon Rowe <simon.rowe@xxxxxxxxxxxxx>]

On 27/09/16 11:06, Wei Liu wrote:
> On Tue, Sep 20, 2016 at 05:29:39PM -0400, Chris Patterson wrote:
> > > From: Chris Patterson <pattersonc@xxxxxxxxxxxx>
> > >
> > > xs_watch() creates a thread to listen to xenstore events.  Currently, the
> > > thread is created with the greater of 16K or PTHREAD_MIN_SIZE.
> > >
> > > There have been several bug reports and workarounds related to the issue
> > > where xs_watch() fails because its attempt to create the reader thread with
> > > pthread_create() fails. This is due to insufficient stack space size
> > > given the requirements for thread-local storage usage in the applications
> > > and libraries that are linked against libxenstore.  [1,2,3,4].
> > >
> > > Specifying the stack size appears to have been added to reduce memory
> > > footprint (1d00c73b983b09fbee4d9dc0f58f6663c361c345).
> > >
> > > This has already been bumped up once to the greater of 16k and
> > > PTHREAD_STACK_MIN (da6a0e86d6a079102abdd0858a19f1e1fae584fc).
> > >
> > > This patch reverts to sticking with the system's default stack size and
> > > removes the code used to set the thread's stack size.
> > >
> > > Of course, the alternative is to bump it to another arbitrary value, but the
> > > requirements may change depending on the application and its libraries that
> > > are linking against xenstore.
> > >
> > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg03341.html
> > > [2] https://lists.xenproject.org/archives/html/xen-users/2016-07/msg00012.html
> > > [3] https://lists.xenproject.org/archives/html/xen-users/2016-07/msg00085.html
> > > [4] https://bugzilla.redhat.com/show_bug.cgi?id=1350264
> > >
> > > Signed-off-by: Chris Patterson <pattersonc@xxxxxxxxxxxx>
> I'm tempted to just ack and apply this patch. If I hear no objection by
> Friday I will do so.
I think the reason we added this patch has gone away,

Simon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel