Re: [Xen-devel] [PATCH] x86: add a user configurable Kconfig option for the VGA

[Derek Straka <derek@xxxxxxxxxxx>]

On Wed, Sep 14, 2016 at 6:47 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 13.09.16 at 21:40, <derek@xxxxxxxxxxx> wrote:
> Allows for the conditional inclusion of VGA driver on the x86 platform
> rather than having it always enabled.

So I guess with all three of these patches an overview mail is missing.
What are you trying to accomplish? Solely reducing the binary size of
Xen doesn't seem like a very important goal to me, and eliminating
these drivers from the build doesn't appear to help make Xen more
stable of secure.

I agree with your assessment on the stability and security standpoint.  Our customer has asked us to remove

unused drivers based on functionality of a set of boards.  Each of the boards has a subset of the available hardware functionality

brought out to accessible headers.  I decided to try to make these items optional via the Kconfig mechanisms already

in place in Xen and contribute the modifications upstream.  I appreciate all of the feedback on the patches, but if they won't

get accepted upstream because they aren't useful, I don't want to continue to waste people's time reviewing these changes.

-Derek

> @@ -672,6 +675,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>
>      printk("Command line: %s\n", cmdline);
>
> +#ifdef CONFIG_VGA
>      printk("Video information:\n");

Some of the other conditionals you add may be affected too, but
here it is most prominent at the first glance - considering that we also
have CONFIG_VIDEO, wouldn't it rather be that one to be used in a
place like this one?

> --- a/xen/include/xen/console.h
> +++ b/xen/include/xen/console.h
> @@ -19,7 +19,15 @@ void console_init_postirq(void);
>  void console_endboot(void);
>  int console_has(const char *device);
>
> +#ifdef CONFIG_VGA
>  int fill_console_start_info(struct dom0_vga_console_info *);
> +#else
> +#include <xen/string.h>
> +static inline int fill_console_start_info(struct dom0_vga_console_info *ci)
> {
> +    (void) memset(ci, 0, sizeof(*ci));

What is this cast to void goo for?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel