Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.09.16 at 16:51, <derek@xxxxxxxxxxx> wrote:
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -51,6 +51,11 @@ config HAS_SCIF
>  
>  config HAS_EHCI
>       bool
> +
> +config EHCI
> +     bool "EHCI debug port" if EXPERT = "y"
> +     default y
> +     depends on HAS_EHCI

While here HAS_EHCI doesn't get left completely useless, I'd still
prefer for it to be dropped, and the select(s) converted to ordinary
dependencies put here. Also please name the variable e.g.
EHCI_DBGP, as there's no full EHCI support in Xen (this was not
really of interest for HAS_EHCI).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel