Re: [Xen-devel] [PATCH v6 05/15] efi: create efi_enabled()

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, Sep 19, 2016 at 05:58:46AM -0600, Jan Beulich wrote:
> >>> On 12.09.16 at 22:18, <daniel.kiper@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/domain_page.c
> > +++ b/xen/arch/x86/domain_page.c
> > @@ -36,7 +36,7 @@ static inline struct vcpu *mapcache_current_vcpu(void)
> >       * domain's page tables but current may point at another domain's VCPU.
> >       * Return NULL as though current is not properly set up yet.
> >       */
> > -    if ( efi_enabled && efi_rs_using_pgtables() )
> > +    if ( efi_enabled(EFI_RS) && efi_rs_using_pgtables() )
>
> I think the efi_enabled() here is pointless now.

Nope, it seems that Xen will blow up on BUG() in
xen/arch/x86/efi/stub.c:efi_rs_using_pgtables() if
compiler/linker cannot be used to build proper PE binary.
Of course we can change efi_rs_using_pgtables() to
return false in such case.

> With this dropped (unless you know of a reason that it needs to stay)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks a lot!

By the way, do you see this patch series (as whole or
at least partially) in 4.8? Should I repost them before
hard freeze? However, I am not sure that it (v7) can be
taken into 4.8 because we are after last posting date.

Wei, Jan, what is your standing in that case?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel