Re: [Xen-devel] [PATCH] x86/cpu: Print CPU Family/Vendor infomation in both decimal and hexidecimal

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/09/16 10:58, Jan Beulich wrote:
>>>> On 12.09.16 at 11:30, <andrew.cooper3@xxxxxxxxxx> wrote:
>> Different manuals use different representations.
>>
>> A new sample looks like:
>>
>> (XEN) CPU Vendor: Intel, Family 6 (0x6), Model 60 (0x3c), Stepping 3 (raw 
>> 000306c3)
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> provided ...
>
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -238,8 +238,10 @@ static void __init early_cpu_detect(void)
>>      c->x86_capability[cpufeat_word(X86_FEATURE_SSE3)] = ecx;
>>  
>>      printk(XENLOG_INFO
>> -           "CPU Vendor: %s, Family %u, Model %u, Stepping %u (raw %08x)\n",
>> -           this_cpu->c_vendor, c->x86, c->x86_model, c->x86_mask, eax);
>> +           "CPU Vendor: %s, Family %u (%#x), Model %u (%#x), "
>> +               "Stepping %u (raw %08x)\n",
>> +           this_cpu->c_vendor, c->x86, c->x86,
>> +               c->x86_model, c->x86_model, c->x86_mask, eax);
> ... you switch back to Linux indentation here.

I already noticed and fixed up locally.

>  I'd also prefer if
> you didn't break the format string across lines, despite if it getting
> long.

Ok - will do.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel