Re: [Xen-devel] [PATCH v4 4/9] version: Print build-id at bootup.

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 09/06/2016 05:57 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Aug 24, 2016 at 02:58:48AM -0600, Jan Beulich wrote:
> > > > > On 24.08.16 at 04:22, <konrad.wilk@xxxxxxxxxx> wrote:
> > > Livepatch expected at some point to be able to print the
> > > build-id during bootup, which it did not.  The reason is
> > > that xen_build_init and livepatch_init are both __initcall
> > > type routines. This meant that when livepatch_init called
> > > xen_build_id, it would return -ENODATA as build_id_len was
> > > not setup yet (b/c xen_build_init would be called later).
> > >
> > > The original patch fixed this by calling xen_build_init in
> > > livepatch_init which allows us to print the build-id of
> > > the hypervisor.
> > >
> > > However the x86 maintainers pointed out that build-id
> > > is independent of Livepatch and in fact should print
> > > regardless whether Livepatch is enabled or not.
> > >
> > > Therefore this patch moves the logic of printing the build-id
> > > to version.c.
> > >
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Thank you.
>
> I had a slight change due to rebasing on "x86/EFI: use less crude a way of 
> generating the build"
> which was quite simple to fix so I retained your Reviewed-by tag.
>
> The final patch looks as so:
>
> From 927c9accac9a49b586f616060e5567d7b03e3e77 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Date: Tue, 6 Sep 2016 12:18:10 -0400
> Subject: [PATCH] version: Print build-id at bootup.
>
> Livepatch expected at some point to be able to print the
> build-id during bootup, which it did not.  The reason is
> that xen_build_init and livepatch_init are both __initcall
> type routines. This meant that when livepatch_init called
> xen_build_id, it would return -ENODATA as build_id_len was
> not setup yet (b/c xen_build_init would be called later).
>
> The original patch fixed this by calling xen_build_init in
> livepatch_init which allows us to print the build-id of
> the hypervisor.
>
> However the x86 maintainers pointed out that build-id
> is independent of Livepatch and in fact should print
> regardless whether Livepatch is enabled or not.
>
> Therefore this patch moves the logic of printing the build-id
> to version.c.
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel