Re: [Xen-devel] [PATCH v2 15/20] livepatch: Move test-cases to common

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.16 at 19:16, <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Aug 25, 2016 at 09:05:27AM -0600, Jan Beulich wrote:
>> >>> On 25.08.16 at 15:37, <konrad.wilk@xxxxxxxxxx> wrote:
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -271,6 +271,7 @@ F:  tools/misc/xen-livepatch.c
>> >  F:  xen/arch/*/livepatch*
>> >  F:  xen/arch/*/*/livepatch*
>> >  F:  xen/common/livepatch*
>> > +F:  xen/test/livepatch/*
>> >  F:  xen/include/xen/livepatch*
>> 
>> Please keep this sorted.
> 
> A side effect of that is that * vs / gets moved too.
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7d42883..507bb40 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -268,10 +268,11 @@ M:  Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>  S:  Supported
>  F:  docs/misc/livepatch.markdown
>  F:  tools/misc/xen-livepatch.c
> -F:  xen/arch/*/livepatch*
>  F:  xen/arch/*/*/livepatch*
> +F:  xen/arch/*/livepatch*
>  F:  xen/common/livepatch*
>  F:  xen/include/xen/livepatch*
> +F:  xen/test/livepatch/*
> 
> You OK with that or would you prefer to leave it as is?

I'd prefer if you just put the addition at the right slot. I don't think
we mean to fully specify collating rules here. Alphabetical / numerical
sorting should be kept, but whether meta-characters like * are
meant to sort before or after alphanumeric ones is, I would say,
simply undefined here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel