Re: [Xen-devel] [PATCH v2 07/20] arm/x86: Add ALTERNATIVE and HAS_EX_TABLE

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Aug 25, 2016 at 08:54:51AM -0600, Jan Beulich wrote:
> >>> On 25.08.16 at 15:37, <konrad.wilk@xxxxxxxxxx> wrote:
> > @@ -22,6 +24,12 @@ config X86
> >     select NUMA
> >     select VGA
> >  
> > +config ALTERNATIVE
> > +   bool
> > +
> > +config HAS_EX_TABLE
> > +   bool
> 
> These need to move out of arch/x86/, and the first one's name is
> too generic (and should probably also start with HAS_).

<nods> Done.

ARM64 is going to look a bit funny as it has ALTERNATIVE
sprinkled and now it will also have an HAS_ALTERNATIVE.

> 
> > --- a/xen/common/livepatch.c
> > +++ b/xen/common/livepatch.c
> > @@ -3,6 +3,7 @@
> >   *
> >   */
> >  
> > +#include <xen/config.h>
> >  #include <xen/cpu.h>
> >  #include <xen/elf.h>
> >  #include <xen/err.h>
> 
> No new explicit inclusions of xen/config.h please.

/me scratches his head.

I need the 'generated/autoconf.h' for its generated names.

Oh, I can just do '#include <xen/kconfig.h>"!


> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel